Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Mark pagination classes with @override decorator #2597

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 9, 2024

Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #2597 will not alter performance

Comparing edgarrmondragon/refactor/pagination-classes-override (bb94b1a) with main (5fc0f75)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (5fc0f75) to head (bb94b1a).
Report is 118 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
+ Coverage   89.48%   89.50%   +0.02%     
==========================================
  Files          58       58              
  Lines        4792     4804      +12     
  Branches      934      943       +9     
==========================================
+ Hits         4288     4300      +12     
  Misses        351      351              
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/pagination-classes-override branch 3 times, most recently from bd4e420 to 468fce8 Compare August 9, 2024 15:58
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/pagination-classes-override branch from 468fce8 to bb94b1a Compare August 9, 2024 17:11
@edgarrmondragon edgarrmondragon merged commit 9e7f71b into main Aug 9, 2024
35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/pagination-classes-override branch August 9, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant