Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Null replication values are now handled when incrementing bookmarks #2438

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 18, 2024

Copy link

codspeed-hq bot commented May 18, 2024

CodSpeed Performance Report

Merging #2438 will not alter performance

Comparing 1714-bug-increment-state-is-breaking-when-new_value-is-null-1 (1fd9a49) with main (e0c5dfd)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (0132f0b) to head (1fd9a49).
Report is 140 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2438   +/-   ##
=======================================
  Coverage   89.18%   89.19%           
=======================================
  Files          54       54           
  Lines        4789     4792    +3     
  Branches      936      937    +1     
=======================================
+ Hits         4271     4274    +3     
  Misses        361      361           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 19, 2024 17:41
@edgarrmondragon edgarrmondragon merged commit 08cddd2 into main May 19, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the 1714-bug-increment-state-is-breaking-when-new_value-is-null-1 branch May 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: increment state is breaking when new_value is null
1 participant