Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Added a condition to the No schema for record field warning #2348

Conversation

tobiascadee
Copy link
Contributor

@tobiascadee tobiascadee commented Mar 27, 2024

If schema flattening is enabled but a value for a key in the record which is flattened is None, this warning is returned because the record can not be flattened and then the key is not in the schema. This can be avoided by checking if the value is None. If it is None the record field actually does not exist so we do not need a warning.


📚 Documentation preview 📚: https://meltano-sdk--2348.org.readthedocs.build/en/2348/

@tobiascadee tobiascadee changed the title fix(target): add a condition to the No schema for record field warning fix(targets): add a condition to the No schema for record field warning Mar 27, 2024
Copy link

codspeed-hq bot commented Mar 27, 2024

CodSpeed Performance Report

Merging #2348 will not alter performance

Comparing tobiascadee:tobias/fix/add-condition-to-no-schema-for-record-warning (a0fac04) with main (acb7487)

Summary

✅ 6 untouched benchmarks

@tobiascadee tobiascadee force-pushed the tobias/fix/add-condition-to-no-schema-for-record-warning branch from 7c093bc to 5b51227 Compare March 27, 2024 13:57
If schema flattening is enabled but a value for a key in the record which is flattened is None, this warning is returned because the record can not be flattened and then the key is not in the schema. This can be avoided by checking if the value is None. If it is None the record field actually does not exist so we do not need a warning.
@tobiascadee tobiascadee force-pushed the tobias/fix/add-condition-to-no-schema-for-record-warning branch from 5b51227 to a0fac04 Compare March 27, 2024 13:58
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.74%. Comparing base (acb7487) to head (a0fac04).
Report is 4 commits behind head on main.

Files Patch % Lines
singer_sdk/sinks/core.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
- Coverage   88.76%   88.74%   -0.02%     
==========================================
  Files          54       54              
  Lines        4771     4772       +1     
  Branches      928      929       +1     
==========================================
  Hits         4235     4235              
  Misses        374      374              
- Partials      162      163       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title fix(targets): add a condition to the No schema for record field warning fix(targets): Added a condition to the No schema for record field warning Apr 3, 2024
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tobiascadee!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Apr 3, 2024
Merged via the queue into meltano:main with commit e64e108 Apr 3, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants