Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Documented BATCH as a default plugin capability #2326

Merged
merged 2 commits into from
Mar 19, 2024
Merged

docs: Documented BATCH as a default plugin capability #2326

merged 2 commits into from
Mar 19, 2024

Conversation

ReubenFrankel
Copy link
Contributor

@ReubenFrankel ReubenFrankel commented Mar 18, 2024 •
edited by github-actions bot
Loading

Is it enough that a tap is built with the SDK for it to support batched files (i.e. batch capability)? These docs seem to suggest it requires an implementation, but the SDK reports it as a supported capability with --about...

https://meltano.slack.com/archives/C068YBV6KEK/p1710531278261849

📚 Documentation preview 📚: https://meltano-sdk--2326.org.readthedocs.build/en/2326/

@ReubenFrankel ReubenFrankel requested review from a team as code owners March 18, 2024 17:35
@ReubenFrankel ReubenFrankel changed the title Document BATCH as a default plugin capability fix: Document BATCH as a default plugin capability Mar 18, 2024
@ReubenFrankel
Copy link
Contributor Author

fix: or docs:?

@edgarrmondragon
Copy link
Collaborator

fix: or docs:?

docs makes more sense imo

@ReubenFrankel ReubenFrankel changed the title fix: Document BATCH as a default plugin capability docs: Document BATCH as a default plugin capability Mar 19, 2024
@edgarrmondragon edgarrmondragon changed the title docs: Document BATCH as a default plugin capability docs: Documented BATCH as a default plugin capability Mar 19, 2024
@edgarrmondragon
Copy link
Collaborator

Thanks @ReubenFrankel!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Mar 19, 2024
Merged via the queue into meltano:main with commit aad9827 Mar 19, 2024
4 checks passed
@ReubenFrankel ReubenFrankel deleted the patch-1 branch March 19, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReubenFrankel @edgarrmondragon