-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(targets): Bumped min joblib dependency to >=1.3.0
and replaced deprecated parallel_backend
with parallel_config
#2288
Conversation
CodSpeed Performance ReportMerging #2288 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2288 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 54 54
Lines 4769 4769
Branches 928 928
=======================================
Hits 4233 4233
Misses 374 374
Partials 162 162 ☔ View full report in Codecov by Sentry. |
I think this requires us to bump the min joblib constraint to https://joblib.readthedocs.io/en/stable/developing.html#release-1-3-0-2023-06-28 (I kinda want to start using uv for its |
>=1.3.0
and replaced deprecated parallel_backend
with parallel_config
Great catch 🥳 I missed that it isn't present until 1.3.0 |
Thanks! |
JobLlib which is used in
Target._drain_all
to accomplish threaded drains of all the sinks utilizesparallel_backend
which has been deprecated. The suggested replaement isparallel_config
.https://joblib.readthedocs.io/en/stable/index.html#deprecated-functionalities
📚 Documentation preview 📚: https://meltano-sdk--2288.org.readthedocs.build/en/2288/