Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Added a jwt package extra, but the cryptography and jwt dependencies are still installed by default for now #2205

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 31, 2024

refactor: Added a jwt package extra. The cryptography and PyJWT dependencies is not yet removed from the default dependencies


📚 Documentation preview 📚: https://meltano-sdk--2205.org.readthedocs.build/en/2205/

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch from 4b9b219 to c0a02b6 Compare January 31, 2024 00:30
Copy link

codspeed-hq bot commented Jan 31, 2024

CodSpeed Performance Report

Merging #2205 will not alter performance

⚠️ No base runs were found

Falling back to comparing edgarrmondragon/refactor/crypto-extra (a40debe) with main (e64e108)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/docs/document-extra-features branch from 70483e3 to 3cc9eb2 Compare January 31, 2024 00:32
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch from c0a02b6 to 9fe083a Compare January 31, 2024 00:33
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (e79d755) to head (a40debe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2205   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files          54       54           
  Lines        4772     4772           
  Branches      929      929           
=======================================
  Hits         4235     4235           
  Misses        374      374           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch from 9fe083a to a02555c Compare January 31, 2024 04:44
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/docs/document-extra-features branch 3 times, most recently from 49a0f77 to e680e59 Compare January 31, 2024 19:16
Base automatically changed from edgarrmondragon/docs/document-extra-features to main January 31, 2024 19:20
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch from a02555c to 00c87dd Compare January 31, 2024 19:27
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch 2 times, most recently from bb5dc5d to 10ff425 Compare February 13, 2024 22:49
@edgarrmondragon edgarrmondragon changed the title refactor: Add a crypto package extra. The cryptography dependency is not yet removed from the default dependencies refactor: Added a crypto package extra. The cryptography dependency is not yet removed from the default dependencies Feb 23, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch from 10ff425 to 741bfba Compare February 23, 2024 16:59
@edgarrmondragon edgarrmondragon changed the title refactor: Added a crypto package extra. The cryptography dependency is not yet removed from the default dependencies refactor: Added a crypto package extra. The cryptography dependency is not yet removed from the default dependencies. Feb 23, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch 2 times, most recently from fc19f78 to fe5e86c Compare February 26, 2024 04:32
@edgarrmondragon edgarrmondragon changed the title refactor: Added a crypto package extra. The cryptography dependency is not yet removed from the default dependencies. refactor: Added a crypto package extra, but the cryptography dependency is still installed by default for now Mar 7, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch 2 times, most recently from f60e646 to 034924f Compare March 8, 2024 02:56
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch from 034924f to 53f9e76 Compare March 20, 2024 20:42
@edgarrmondragon edgarrmondragon changed the title refactor: Added a crypto package extra, but the cryptography dependency is still installed by default for now refactor: Added a jwt package extra, but the cryptography and jwt dependencies are still installed by default for now Mar 20, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/crypto-extra branch 4 times, most recently from ebebcb0 to 857ca18 Compare March 20, 2024 21:00
… dependencies are not yet removed from the default dependencies
@edgarrmondragon edgarrmondragon marked this pull request as ready for review April 4, 2024 17:54
@edgarrmondragon edgarrmondragon requested review from a team as code owners April 4, 2024 17:54
@edgarrmondragon edgarrmondragon added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit a65c561 Apr 4, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/crypto-extra branch April 4, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants