Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): Ensure .vscode directory is included when requested in cookiecutters and avoid failing if it does not exist #2183

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 25, 2024

Closes #2182


📚 Documentation preview 📚: https://meltano-sdk--2183.org.readthedocs.build/en/2183/

@edgarrmondragon edgarrmondragon linked an issue Jan 25, 2024 that may be closed by this pull request
1 task
@edgarrmondragon edgarrmondragon changed the title fix(template): Ensure .vscode directory is included when requested in cookiecutters and do not fail if it does not exist fix(templates): Ensure .vscode directory is included when requested in cookiecutters and do not fail if it does not exist Jan 25, 2024
@edgarrmondragon edgarrmondragon changed the title fix(templates): Ensure .vscode directory is included when requested in cookiecutters and do not fail if it does not exist fix(templates): Ensure .vscode directory is included when requested in cookiecutters and avoid failing if it does not exist Jan 25, 2024
@edgarrmondragon edgarrmondragon force-pushed the 2182-bug-cookiecutter-tap-template-errors-out-if-vscode-ide-is-not-selected branch from 2e7cff2 to bfc5a30 Compare January 25, 2024 23:37
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (392b1c7) 88.49% compared to head (4e94848) 88.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2183   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          54       54           
  Lines        4711     4711           
  Branches      961      961           
=======================================
  Hits         4169     4169           
  Misses        384      384           
  Partials      158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…in cookiecutters and do not fail if it does not exist
@edgarrmondragon edgarrmondragon force-pushed the 2182-bug-cookiecutter-tap-template-errors-out-if-vscode-ide-is-not-selected branch from bfc5a30 to 4e94848 Compare January 25, 2024 23:41
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 25, 2024 23:53
@edgarrmondragon edgarrmondragon merged commit 98d4375 into main Jan 25, 2024
31 checks passed
@edgarrmondragon edgarrmondragon deleted the 2182-bug-cookiecutter-tap-template-errors-out-if-vscode-ide-is-not-selected branch January 25, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cookiecutter tap-template errors out if VSCode IDE is not selected
1 participant