Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Drop support for Python 3.7 #2143

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 10, 2024

Backport from the V1 branch to maybe ship this earlier?


📚 Documentation preview 📚: https://meltano-sdk--2143.org.readthedocs.build/en/2143/

Copy link

codspeed-hq bot commented Jan 10, 2024

CodSpeed Performance Report

Merging #2143 will not alter performance

Comparing edgarrmondragon/refactor/drop-py37 (5aa89bb) with main (82abb06)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82abb06) 88.35% compared to head (5aa89bb) 88.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   88.35%   88.32%   -0.03%     
==========================================
  Files          54       54              
  Lines        4696     4686      -10     
  Branches      957      955       -2     
==========================================
- Hits         4149     4139      -10     
  Misses        389      389              
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/drop-py37 branch 6 times, most recently from fed8c9c to da6c93e Compare January 16, 2024 18:09
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/drop-py37 branch 3 times, most recently from bd8a84a to bbd0e5d Compare January 22, 2024 15:40
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 22, 2024 15:45
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners January 22, 2024 15:45
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/drop-py37 branch from bbd0e5d to 2f366b5 Compare January 22, 2024 15:56
Backport from the V1 branch to maybe release this earlier?
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/drop-py37 branch from 2f366b5 to 5aa89bb Compare January 22, 2024 15:58
@edgarrmondragon edgarrmondragon added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit c9c0b0b Jan 22, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/drop-py37 branch January 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants