Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken requests documentation links #2111

Conversation

mjsqu
Copy link
Contributor

@mjsqu mjsqu commented Dec 18, 2023

@mjsqu mjsqu changed the title Fix broken requests documentation links docs: Fix broken requests documentation links Dec 18, 2023
@mjsqu
Copy link
Contributor Author

mjsqu commented Dec 18, 2023

As described, prior to this change all docstrings pointing to requests.readthedocs.io pages were broken due to a reshuffling of the requests package documentation

Copy link

codspeed-hq bot commented Dec 18, 2023

CodSpeed Performance Report

Merging #2111 will not alter performance

Comparing mjsqu:docs/broken_links_in_requests_readthedocs_docstrings (7d8cf34) with main (544f61f)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (544f61f) 87.76% compared to head (7d8cf34) 87.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2111   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          60       60           
  Lines        4946     4946           
  Branches     1007     1007           
=======================================
  Hits         4341     4341           
  Misses        424      424           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjsqu!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Dec 18, 2023
Merged via the queue into meltano:main with commit 40b6333 Dec 18, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants