Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use datetime.fromisoformat in other places #2092

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 7, 2023

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fe0ff85) 87.70% compared to head (94b99e3) 87.71%.
Report is 1 commits behind head on main.

Files Patch % Lines
singer_sdk/testing/tap_tests.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2092      +/-   ##
==========================================
+ Coverage   87.70%   87.71%   +0.01%     
==========================================
  Files          60       60              
  Lines        4937     4942       +5     
  Branches     1005     1007       +2     
==========================================
+ Hits         4330     4335       +5     
  Misses        425      425              
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 7, 2023

CodSpeed Performance Report

Merging #2092 will not alter performance

Comparing edgarrmondragon/refactor/more-datetime.fromisoformat (94b99e3) with main (fcf30d5)

Summary

✅ 4 untouched benchmarks

@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 7, 2023 15:50
@edgarrmondragon edgarrmondragon merged commit d755024 into main Dec 7, 2023
51 of 53 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/more-datetime.fromisoformat branch December 7, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant