fix(deps): Make a explicit dependency on python-dateutil
#2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2076 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2076 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 60 60
Lines 4940 4940
Branches 1006 1006
=======================================
Hits 4330 4330
Misses 429 429
Partials 181 181 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
changed the title
python-dateutilpython-dateutil
Currently we have a _transitive_ dependency on [`python-dateutil`](https://github.com/dateutil/dateutil) via [`pendulum`](https://github.com/sdispater/pendulum). We actually rely on direct calls to its API, so it's better to list it as an explicit dependency to allow breaking stuff if we ever remove the dependency on Pendulum.
edgarrmondragon
force-pushed
the
edgarrmondragon/fix/python-dateutil-dep
branch
from
df6a19f to
05242ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a transitive dependency on
python-dateutilviapendulum.We actually rely on direct calls to its API, so it's better to list it as an explicit dependency in order not to break more stuff than necessary if we ever remove the dependency on Pendulum.
📚 Documentation preview 📚: https://meltano-sdk--2076.org.readthedocs.build/en/2076/