Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parse record time_extracted into datetime.datetime instance #2006

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 9, 2023

Closes #1902


📚 Documentation preview 📚: https://meltano-sdk--2006.org.readthedocs.build/en/2006/

@edgarrmondragon edgarrmondragon changed the title fix: Parse record time_extracted into datetime instance fix: Parse record time_extracted into datetime.datetime instance Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2006 (2a3be49) into main (7e83cc0) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
+ Coverage   87.40%   87.42%   +0.01%     
==========================================
  Files          59       59              
  Lines        5131     5136       +5     
  Branches      830      830              
==========================================
+ Hits         4485     4490       +5     
  Misses        451      451              
  Partials      195      195              
Files Coverage Δ
singer_sdk/_singerlib/messages.py 97.77% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 9, 2023 17:00
@edgarrmondragon edgarrmondragon merged commit b045ef7 into main Oct 9, 2023
@edgarrmondragon edgarrmondragon deleted the 1902-bug-mapper-built-on-sdk-errors-with-attributeerror-str-object-has-no-attribute-tzinfo branch October 9, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: mapper built on SDK errors with AttributeError: 'str' object has no attribute 'tzinfo
1 participant