Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix hanging downstream tests in tap-postgres #1977

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 22, 2023

@edgarrmondragon edgarrmondragon linked an issue Sep 22, 2023 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1977 (b247497) into main (bb98db5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1977   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files          59       59           
  Lines        5120     5120           
  Branches      827      827           
=======================================
  Hits         4463     4463           
  Misses        463      463           
  Partials      194      194           
Files Changed Coverage Δ
singer_sdk/connectors/sql.py 84.15% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 22, 2023 15:19
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners September 22, 2023 15:19
@edgarrmondragon
Copy link
Collaborator Author

Fixed: MeltanoLabs/tap-postgres#236

@edgarrmondragon edgarrmondragon merged commit fa25c46 into main Sep 22, 2023
26 checks passed
@edgarrmondragon edgarrmondragon deleted the 1973-bug-standard-tests-hang-in-tap-postgres branch September 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Standard tests hang in tap-postgres
1 participant