fix(targets): missing begin()s related to SQLAlchemy 2.0 #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1954 +/- ##
==========================================
+ Coverage 87.01% 87.08% +0.07%
==========================================
Files 59 59
Lines 5112 5112
Branches 827 827
==========================================
+ Hits 4448 4452 +4
+ Misses 468 465 -3
+ Partials 196 195 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Thanks @andyoneal! This revealed some untested paths so I pushed tests to your branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds begin() to three other functions where schema is added or columns are altered. because of the changes made to auto-commit in SQLAlchemy 2.0, without begin() the ddl is rolled back.
matches style used in _create_empty_column()
📚 Documentation preview 📚: https://meltano-sdk--1954.org.readthedocs.build/en/1954/