Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Correctly serialize decimal.Decimal in JSON fields of SQL targets #1898

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 7, 2023

Closes #1897


📚 Documentation preview 📚: https://meltano-sdk--1898.org.readthedocs.build/en/1898/

@edgarrmondragon edgarrmondragon self-assigned this Aug 7, 2023
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 7, 2023 19:33
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1898 (4244e6b) into main (bb56a1a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
+ Coverage   86.93%   86.94%   +0.01%     
==========================================
  Files          59       59              
  Lines        5073     5080       +7     
  Branches      822      822              
==========================================
+ Hits         4410     4417       +7     
  Misses        466      466              
  Partials      197      197              
Files Changed Coverage Δ
singer_sdk/connectors/sql.py 81.91% <100.00%> (+0.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner August 7, 2023 20:30
@edgarrmondragon edgarrmondragon merged commit af2e488 into main Aug 7, 2023
@edgarrmondragon edgarrmondragon deleted the 1897-bug-serialization-of-decimaldecimal-values-in-json-fields-is-failing-for-sql-targets branch August 7, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Serialization of decimal.Decimal values in JSON fields is failing for SQL targets
2 participants