-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Expose add_record_metadata
as a builtin target setting
#1881
Merged
edgarrmondragon
merged 11 commits into
main
from
1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
Jul 31, 2023
Merged
fix: Expose add_record_metadata
as a builtin target setting
#1881
edgarrmondragon
merged 11 commits into
main
from
1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1881 +/- ##
=======================================
Coverage 86.92% 86.93%
=======================================
Files 59 59
Lines 5071 5073 +2
Branches 822 822
=======================================
+ Hits 4408 4410 +2
Misses 466 466
Partials 197 197
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
force-pushed
the
1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
branch
from
July 27, 2023 18:56
6314f21
to
0fc6b51
Compare
edgarrmondragon
changed the base branch from
main
to
1879-bug-batch-config-schema-is-not-appended-to-targets-own-config-schema-if-the-target-supports-the-batch-capability
July 27, 2023 18:56
…-to-targets-own-config-schema-if-the-target-supports-the-batch-capability
…-own-config-schema-if-the-target-supports-the-batch-capability' into 1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
…-own-config-schema-if-the-target-supports-the-batch-capability' into 1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
…-to-targets-own-config-schema-if-the-target-supports-the-batch-capability
…-own-config-schema-if-the-target-supports-the-batch-capability' into 1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
Base automatically changed from
1879-bug-batch-config-schema-is-not-appended-to-targets-own-config-schema-if-the-target-supports-the-batch-capability
to
main
July 31, 2023 13:33
…be-surfaced-as-builtin-target-configuration
pnadolny13
approved these changes
Jul 31, 2023
edgarrmondragon
deleted the
1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
branch
July 31, 2023 19:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1199
📚 Documentation preview 📚: https://meltano-sdk--1881.org.readthedocs.build/en/1881/