Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose add_record_metadata as a builtin target setting #1881

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 27, 2023

Closes #1199


📚 Documentation preview 📚: https://meltano-sdk--1881.org.readthedocs.build/en/1881/

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1881 (45c2947) into main (c3a8f90) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1881   +/-   ##
=======================================
  Coverage   86.92%   86.93%           
=======================================
  Files          59       59           
  Lines        5071     5073    +2     
  Branches      822      822           
=======================================
+ Hits         4408     4410    +2     
  Misses        466      466           
  Partials      197      197           
Files Changed Coverage Δ
singer_sdk/helpers/capabilities.py 91.80% <100.00%> (+0.13%) ⬆️
singer_sdk/target_base.py 92.30% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the 1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration branch from 6314f21 to 0fc6b51 Compare July 27, 2023 18:56
@edgarrmondragon edgarrmondragon changed the base branch from main to 1879-bug-batch-config-schema-is-not-appended-to-targets-own-config-schema-if-the-target-supports-the-batch-capability July 27, 2023 18:56
…-to-targets-own-config-schema-if-the-target-supports-the-batch-capability
…-own-config-schema-if-the-target-supports-the-batch-capability' into 1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
…-own-config-schema-if-the-target-supports-the-batch-capability' into 1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
…-to-targets-own-config-schema-if-the-target-supports-the-batch-capability
…-own-config-schema-if-the-target-supports-the-batch-capability' into 1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration
Base automatically changed from 1879-bug-batch-config-schema-is-not-appended-to-targets-own-config-schema-if-the-target-supports-the-batch-capability to main July 31, 2023 13:33
@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 31, 2023 13:46
@edgarrmondragon edgarrmondragon requested a review from kgpayne as a code owner July 31, 2023 13:46
@edgarrmondragon edgarrmondragon merged commit 611d50d into main Jul 31, 2023
@edgarrmondragon edgarrmondragon deleted the 1199-bug-setting-add_record_metadata-should-be-surfaced-as-builtin-target-configuration branch July 31, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Setting add_record_metadata should be surfaced as builtin target configuration
2 participants