Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add _sdc_sync_started_at metadata column to indicate the start of the target process #1878

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 27, 2023

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1878 (22134f9) into main (b0a8621) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
+ Coverage   86.73%   86.87%   +0.14%     
==========================================
  Files          59       59              
  Lines        5019     5027       +8     
  Branches      814      814              
==========================================
+ Hits         4353     4367      +14     
+ Misses        470      464       -6     
  Partials      196      196              
Files Changed Coverage Δ
singer_sdk/sinks/sql.py 90.35% <ø> (ø)
singer_sdk/plugin_base.py 86.56% <100.00%> (+0.34%) ⬆️
singer_sdk/sinks/core.py 88.88% <100.00%> (+3.98%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 27, 2023 18:29
@edgarrmondragon edgarrmondragon requested a review from kgpayne as a code owner July 27, 2023 18:29
Copy link
Contributor

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon great work! Looks good to me

@edgarrmondragon edgarrmondragon merged commit b1b3bd2 into main Jul 27, 2023
@edgarrmondragon edgarrmondragon deleted the feat/sdc-initialization-timestamp branch July 27, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants