Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQLTap connector instance shared with streams #1861

Conversation

BuzzCutNorman
Copy link
Contributor

@BuzzCutNorman BuzzCutNorman commented Jul 20, 2023

This adds a variable _tap_connector to SQLTap to house an instance of the default_stream_class.connector_class and a property to access it. The catalog_dict and discover_streams methods were updated to utilize the new property.

Closes #1773


📚 Documentation preview 📚: https://meltano-sdk--1861.org.readthedocs.build/en/1861/

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1861 (ace7142) into main (efca24f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1861      +/-   ##
==========================================
+ Coverage   86.95%   86.97%   +0.01%     
==========================================
  Files          59       59              
  Lines        5084     5090       +6     
  Branches      823      824       +1     
==========================================
+ Hits         4421     4427       +6     
  Misses        466      466              
  Partials      197      197              
Files Changed Coverage Δ
singer_sdk/tap_base.py 83.84% <100.00%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BuzzCutNorman BuzzCutNorman marked this pull request as ready for review July 20, 2023 18:53
@BuzzCutNorman
Copy link
Contributor Author

Just wanted to check in on this PR. Thanks

@edgarrmondragon
Copy link
Collaborator

I'm gonna give this a try with MeltanoLabs/tap-postgres

@edgarrmondragon edgarrmondragon merged commit ce4b9a7 into meltano:main Aug 17, 2023
@edgarrmondragon
Copy link
Collaborator

Thanks @BuzzCutNorman!

@BuzzCutNorman BuzzCutNorman deleted the 1733-tap-level-connector-instance-shared-with-streams branch November 28, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Tap level SQLAlchemy connector instance shared with Streams
3 participants