Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add deprecation warning when importing legacy testing helpers #1838

Merged
merged 13 commits into from
Jul 21, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 14, 2023

In preparation for #1354 in v1


📚 Documentation preview 📚: https://meltano-sdk--1838.org.readthedocs.build/en/1838/

@edgarrmondragon edgarrmondragon changed the title fix: Add deprecation warning when import legacy testing helpers fix: Add deprecation warning when importing legacy testing helpers Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1838 (5dc8e97) into main (c444601) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   86.68%   86.71%   +0.03%     
==========================================
  Files          59       59              
  Lines        5000     5013      +13     
  Branches      811      813       +2     
==========================================
+ Hits         4334     4347      +13     
  Misses        470      470              
  Partials      196      196              
Impacted Files Coverage Δ
singer_sdk/testing/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 14, 2023 23:29
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners July 14, 2023 23:29
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) July 18, 2023 20:26
@edgarrmondragon edgarrmondragon disabled auto-merge July 21, 2023 20:19
@edgarrmondragon edgarrmondragon merged commit 52802e6 into main Jul 21, 2023
@edgarrmondragon edgarrmondragon deleted the change/deprecate-legacy-testing branch July 21, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants