Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: poetry lock contains packaging module - pyproject.toml does not #1822

Closed
mjsqu opened this issue Jul 10, 2023 · 3 comments · Fixed by #1827
Closed

bug: poetry lock contains packaging module - pyproject.toml does not #1822

mjsqu opened this issue Jul 10, 2023 · 3 comments · Fixed by #1827
Assignees
Labels
Dependencies kind/Bug Something isn't working

Comments

@mjsqu
Copy link
Contributor

mjsqu commented Jul 10, 2023

https://github.com/meltano/sdk/blame/ba8c43c40957a599374ad32697a391b171610e04/singer_sdk/plugin_base.py#L15

@mjsqu
Copy link
Contributor Author

mjsqu commented Jul 10, 2023

A colleague has just been using the latest version of the SDK and installing from the pyproject.toml and then running with meltano fails with packaging not found.

@s7clarke10
Copy link
Contributor

Here is a bit more detail around the issue running with the latest SDK.

meltano --log-level=debug invoke tap-rest-api-msdk--MDR --discover
Traceback (most recent call last):
  File "/home/my_user/meltano-projects/salesforce_pot/.meltano/extractors/tap-rest-api-msdk/venv/bin/tap-rest-api-msdk", line 5, in <module>
    from tap_rest_api_msdk.tap import TapRestApiMsdk
  File "/home/my_user/meltano-projects/salesforce_pot/.meltano/extractors/tap-rest-api-msdk/venv/lib64/python3.8/site-packages/tap_rest_api_msdk/tap.py", line 9, in <module>
    from singer_sdk import Tap
  File "/home/my_user/meltano-projects/salesforce_pot/.meltano/extractors/tap-rest-api-msdk/venv/lib64/python3.8/site-packages/singer_sdk/__init__.py", line 7, in <module>
    from singer_sdk.mapper_base import InlineMapper
  File "/home/my_user/meltano-projects/salesforce_pot/.meltano/extractors/tap-rest-api-msdk/venv/lib64/python3.8/site-packages/singer_sdk/mapper_base.py", line 14, in <module>
    from singer_sdk.plugin_base import PluginBase
  File "/home/my_user/meltano-projects/salesforce_pot/.meltano/extractors/tap-rest-api-msdk/venv/lib64/python3.8/site-packages/singer_sdk/plugin_base.py", line 15, in <module>
    from packaging.specifiers import SpecifierSet
ModuleNotFoundError: No module named 'packaging'

I believe package was just added two day ago here:

from packaging.specifiers import SpecifierSet
but has not been added to the pyproject.toml file so Meltano is failing because package is not available in my venv.

@edgarrmondragon
Copy link
Collaborator

Thanks for reporting! This merits a patch release right after we fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies kind/Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants