Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Include SCHEMA message count in target logs #1820

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 7, 2023

From a (private) Slack conversation, it seems that we're missing the SCHEMA message count which makes it seem that the total is missing something.

Example of new output:

2023-07-07 12:46:08,109 | INFO     | target-csv           | Target 'target-csv' completed reading 262 lines of input (2 schemas, 257 records, 0 batch manifests, 3 state messages).

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1820 (82cbba6) into main (5bc4c57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1820   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files          59       59           
  Lines        4996     4996           
  Branches      816      816           
=======================================
  Hits         4318     4318           
  Misses        479      479           
  Partials      199      199           
Impacted Files Coverage Δ
singer_sdk/target_base.py 92.55% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 7, 2023 18:47
@edgarrmondragon edgarrmondragon requested a review from kgpayne as a code owner July 7, 2023 18:47
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) July 7, 2023 18:47
Copy link
Contributor

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon edgarrmondragon merged commit ba8c43c into main Jul 7, 2023
@edgarrmondragon edgarrmondragon deleted the fix/target-count-include-schemas branch July 7, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants