Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish supported python versions in --about #1800

Merged
merged 13 commits into from
Jul 7, 2023
Merged

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Jun 29, 2023

Closes #1628
Closes #1403

@kgpayne kgpayne requested a review from edgarrmondragon as a code owner June 29, 2023 13:41
@kgpayne kgpayne requested a review from WillDaSilva June 29, 2023 13:56
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1800 (398c905) into main (0d1b918) will decrease coverage by 0.08%.
The diff coverage is 86.95%.

❗ Current head 398c905 differs from pull request most recent head b646de2. Consider uploading reports for the commit b646de2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   86.44%   86.37%   -0.08%     
==========================================
  Files          59       59              
  Lines        4974     4992      +18     
  Branches      813      816       +3     
==========================================
+ Hits         4300     4312      +12     
- Misses        476      481       +5     
- Partials      198      199       +1     
Impacted Files Coverage Δ
singer_sdk/about.py 98.36% <85.71%> (-1.64%) ⬇️
singer_sdk/plugin_base.py 84.06% <87.50%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

singer_sdk/plugin_base.py Show resolved Hide resolved
singer_sdk/plugin_base.py Outdated Show resolved Hide resolved
singer_sdk/plugin_base.py Outdated Show resolved Hide resolved
singer_sdk/plugin_base.py Outdated Show resolved Hide resolved
@kgpayne
Copy link
Contributor Author

kgpayne commented Jul 5, 2023

@edgarrmondragon FYI. We talked about this in our ☕️ chat, and you mentioned using a different approach in tap-linkedin? How do you feel about adding an optional package_name attr to facilitate lookups of the package version and other package metadata?

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a single nit/suggestion.

singer_sdk/plugin_base.py Outdated Show resolved Hide resolved
Ken Payne and others added 2 commits July 5, 2023 18:55
@edgarrmondragon
Copy link
Collaborator

@kgpayne I pushed a fix for mypy. Feel free to merge!

@kgpayne kgpayne enabled auto-merge (squash) July 7, 2023 14:55
@kgpayne kgpayne merged commit 2ba140b into main Jul 7, 2023
@kgpayne kgpayne deleted the kgpayne/issue1628 branch July 7, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants