-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: publish supported python versions in --about
#1800
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
- Coverage 86.44% 86.37% -0.08%
==========================================
Files 59 59
Lines 4974 4992 +18
Branches 813 816 +3
==========================================
+ Hits 4300 4312 +12
- Misses 476 481 +5
- Partials 198 199 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Will Da Silva <[email protected]>
@edgarrmondragon FYI. We talked about this in our ☕️ chat, and you mentioned using a different approach in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a single nit/suggestion.
Co-authored-by: Edgar R. M. <[email protected]>
@kgpayne I pushed a fix for mypy. Feel free to merge! |
Closes #1628
Closes #1403