Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create batch directory if missing #1796

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Jun 28, 2023

Closes #1014


📚 Documentation preview 📚: https://meltano-sdk--1796.org.readthedocs.build/en/1796/

@kgpayne kgpayne requested a review from edgarrmondragon as a code owner June 28, 2023 14:34
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1796 (d7709c8) into main (5f59f38) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1796   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files          59       59           
  Lines        4960     4960           
  Branches      811      811           
=======================================
  Hits         4280     4280           
  Misses        481      481           
  Partials      199      199           
Impacted Files Coverage Δ
singer_sdk/batch.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title fix: create batch dir if missing fix: Create batch directory if missing Jul 3, 2023
@edgarrmondragon edgarrmondragon merged commit d228ab0 into main Jul 4, 2023
@edgarrmondragon edgarrmondragon deleted the kgpayne/create-batch-dir-if-missing branch July 4, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: New BATCH functionality fails if output folder is missing
2 participants