Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sql targets: migrate insert_records to sqlalchemy #1767

Closed
visch opened this issue Jun 15, 2023 · 1 comment
Closed

feat: sql targets: migrate insert_records to sqlalchemy #1767

visch opened this issue Jun 15, 2023 · 1 comment
Labels

Comments

@visch
Copy link
Contributor

visch commented Jun 15, 2023

Feature scope

Taps (catalog, state, stream maps, etc.)

Description

Right now there's a lot of "manual" interaction with the database for SQL. Example implementation MeltanoLabs/target-postgres#138 .

Current code
https://github.com/meltano/sdk/blob/3ceb28a97a77a5e22163fc887fe16ff129c2dc28/singer_sdk/sinks/sql.py#LL318C27-L318C52

@visch visch added kind/Feature New feature or request valuestream/SDK labels Jun 15, 2023
@visch visch changed the title feat: sql taps/targets: migrate insert_records to sqlalchemy feat: sql targets: migrate insert_records to sqlalchemy Jun 15, 2023
Copy link

stale bot commented Jun 14, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jun 14, 2024
@stale stale bot closed this as completed Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant