Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taps): Always emit a STATE message at the start of the sync process #1753

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jun 6, 2023

Closes #1750


📚 Documentation preview 📚: https://meltano-sdk--1753.org.readthedocs.build/en/1753/

@edgarrmondragon edgarrmondragon requested a review from kgpayne as a code owner June 6, 2023 18:31
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1753 (f848a0e) into main (a64c660) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   85.48%   85.52%   +0.04%     
==========================================
  Files          59       59              
  Lines        4891     4892       +1     
  Branches      803      803              
==========================================
+ Hits         4181     4184       +3     
+ Misses        510      509       -1     
+ Partials      200      199       -1     
Impacted Files Coverage Δ
singer_sdk/tap_base.py 74.09% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon merged commit cf57439 into main Jun 7, 2023
@edgarrmondragon edgarrmondragon deleted the fix/emit-state-at-start branch June 7, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: STATE not emitted if get_records produces no values
2 participants