-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: break out default batch file writer into separate class #1668
Conversation
for more information, see https://pre-commit.ci
…ltano/sdk into kgpayne/refactor-default-batch-writer
Codecov Report
@@ Coverage Diff @@
## main #1668 +/- ##
==========================================
+ Coverage 85.05% 85.07% +0.01%
==========================================
Files 58 59 +1
Lines 4845 4864 +19
Branches 805 807 +2
==========================================
+ Hits 4121 4138 +17
- Misses 526 527 +1
- Partials 198 199 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@edgarrmondragon this is to better reuse batch file writers on the target side. I.e. cases where the target supports batch files (in json or csv) but receives records. E.g. target-snowflake |
@kgpayne This is looking great. Should we document these new batcher classes in the reference section (which is actually getting crowded imo)? |
📚 Documentation preview 📚: https://meltano-sdk--1668.org.readthedocs.build/en/1668/