Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Consolidate config parsing for all plugin base classes #1610

Merged
merged 5 commits into from
Apr 18, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Apr 14, 2023

Moves the processing of --config option values to detect ENV to an static method config_from_cli_args in the PluginBase class.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #1610 (4c4d912) into main (182d363) will increase coverage by 0.16%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##             main    #1610      +/-   ##
==========================================
+ Coverage   86.25%   86.41%   +0.16%     
==========================================
  Files          58       58              
  Lines        4771     4761      -10     
  Branches      801      798       -3     
==========================================
- Hits         4115     4114       -1     
+ Misses        465      456       -9     
  Partials      191      191              
Impacted Files Coverage Δ
singer_sdk/mapper_base.py 54.71% <0.00%> (-1.43%) ⬇️
singer_sdk/tap_base.py 71.56% <0.00%> (+2.47%) ⬆️
singer_sdk/plugin_base.py 85.89% <61.53%> (-2.30%) ⬇️
singer_sdk/target_base.py 87.83% <100.00%> (+1.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WillDaSilva WillDaSilva removed the request for review from aaronsteers April 17, 2023 21:50
@edgarrmondragon edgarrmondragon requested review from kgpayne and WillDaSilva and removed request for cjohnhanson April 18, 2023 20:10
@edgarrmondragon edgarrmondragon merged commit 43f7323 into main Apr 18, 2023
@edgarrmondragon edgarrmondragon deleted the refactor/consolidate-config-parsing branch April 18, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants