fix: Conform metric field type to Singer spec
#1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [Singer Spec](https://github.com/singer-io/getting-started/blob/master/docs/SYNC_MODE.md#metric-messages), the correct field name is `type` and not `metric_type`.
Codecov Report
@@ Coverage Diff @@
## main #1574 +/- ##
=======================================
Coverage 85.59% 85.59%
=======================================
Files 57 57
Lines 4726 4726
Branches 807 807
=======================================
Hits 4045 4045
Misses 488 488
Partials 193 193
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
requested review from
cjohnhanson and
aaronsteers
as code owners
WillDaSilva
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Singer Spec, the correct field name is
typeand notmetric_type.📚 Documentation preview 📚: https://meltano-sdk--1574.org.readthedocs.build/en/1574/