Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle missing type value when checking JSON schema types #1526

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Mar 24, 2023

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1526 (128496a) into main (97b4906) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1526   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files          57       57           
  Lines        4692     4692           
  Branches      802      802           
=======================================
  Hits         4012     4012           
  Misses        489      489           
  Partials      191      191           
Impacted Files Coverage Δ
singer_sdk/helpers/_typing.py 74.19% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon self-assigned this Mar 24, 2023
@mjsqu
Copy link
Contributor

mjsqu commented Mar 24, 2023

Looks good, in the case we found in tap-dbt, this would loop over the "anyOf" list and skip past "enum" without returning anything but output True when encountering the "type" key. The test looks exactly like the case in tap-dbt. Great work @edgarrmondragon 👍

@edgarrmondragon edgarrmondragon marked this pull request as ready for review March 24, 2023 13:23
@edgarrmondragon edgarrmondragon merged commit f943fa3 into main Mar 24, 2023
@edgarrmondragon edgarrmondragon deleted the fix/missing-type-value branch March 24, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants