Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added RESTStream.backoff_jitter to support custom backoff jitter generators #1480

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

visch
Copy link
Contributor

@visch visch commented Mar 4, 2023

Closes #1477


📚 Documentation preview 📚: https://meltano-sdk--1480.org.readthedocs.build/en/1480/

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1480 (ce4167b) into main (0d62f88) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head ce4167b differs from pull request most recent head 48583f0. Consider uploading reports for the commit 48583f0 to get more accurate results

@@            Coverage Diff             @@
##             main    #1480      +/-   ##
==========================================
- Coverage   85.46%   85.44%   -0.02%     
==========================================
  Files          57       57              
  Lines        4760     4762       +2     
  Branches      809      809              
==========================================
+ Hits         4068     4069       +1     
- Misses        501      502       +1     
  Partials      191      191              
Impacted Files Coverage Δ
singer_sdk/streams/rest.py 85.97% <50.00%> (-0.45%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @visch!

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) March 6, 2023 15:13
@edgarrmondragon edgarrmondragon disabled auto-merge March 6, 2023 15:13
@edgarrmondragon edgarrmondragon changed the title feat: backoff_jitter feat: Added RESTStream.backoff_jitter to support custom backoff jitter generators Mar 6, 2023
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) March 6, 2023 15:19
@edgarrmondragon edgarrmondragon merged commit 1238def into meltano:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Custom-Backoff header sample doesn't work due to backoff defaulting to "full jittter"
2 participants