[Bug]: Inconsistent config naming in cookiecutter

[radbrt]

Singer SDK Version

0.21.0

Is this a regression?

• Yes

Python Version

NA

Bug scope

Taps (catalog, state, stream maps, etc.)

Operating System

Mac

Description

In the cookiecutter tap template, one of the configs in tap.py is auth_token:

sdk/cookiecutter/tap-template/{{cookiecutter.tap_id}}/{{cookiecutter.library_name}}/tap.py

Line 26 in 774a176

"auth_token",

In the client.py file for REST targets however, the code references a config named api_key:

sdk/cookiecutter/tap-template/{{cookiecutter.tap_id}}/{{cookiecutter.library_name}}/{%if 'REST' == cookiecutter.stream_type %}client.py{%endif%}

Line 89 in 774a176

value=self.config.get("api_key", ""),

My hunch is that client.py for REST taps should reference auth_token as that is what the graphQL template does.

If anyone agrees, I'll make a PR. As it is today, this config name has to be changed for the tap to run.

Code

No response

[tayloramurphy]

@aaronsteers @edgarrmondragon can you add your thoughts on this?

[edgarrmondragon]

@tayloramurphy Yeah, we should change the client.py template to use auth_token instead, for consistency.

I'd say a PR is welcome @radbrt 🙂