Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): E2E Cookiecutter - Cover all REST authentication cases + one GraphQL case #1428

Merged

Conversation

flexponsive
Copy link
Contributor

@flexponsive flexponsive commented Feb 16, 2023

Follow-up to #1410

  • Expands the coverage of the end-to-test for cookiecutters to cover all authentication methods for REST
  • Fixes misc issues discovered by mypy, including a missing import
  • Add a test case for GraphQL

📚 Documentation preview 📚: https://meltano-sdk--1428.org.readthedocs.build/en/1428/

@flexponsive flexponsive changed the title E2E Cookiecutter: Cover all REST authentication cases + one GraphQL case feat: E2E Cookiecutter - Cover all REST authentication cases + one GraphQL case Feb 16, 2023
@flexponsive flexponsive force-pushed the e2e_cookiecutter_all_rest_auth branch from 0bbef21 to 72ab84c Compare February 16, 2023 14:19
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1428 (dd1a260) into main (14d7aa1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1428   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files          57       57           
  Lines        4763     4763           
  Branches      808      808           
=======================================
  Hits         4071     4071           
  Misses        501      501           
  Partials      191      191           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tayloramurphy
Copy link
Collaborator

Thanks for the PR @flexponsive ! We'll get one of the engineers to review @meltano/engineering

@edgarrmondragon edgarrmondragon changed the title feat: E2E Cookiecutter - Cover all REST authentication cases + one GraphQL case ci(templates): E2E Cookiecutter - Cover all REST authentication cases + one GraphQL case Feb 16, 2023
@edgarrmondragon edgarrmondragon changed the title ci(templates): E2E Cookiecutter - Cover all REST authentication cases + one GraphQL case fix(templates): E2E Cookiecutter - Cover all REST authentication cases + one GraphQL case Feb 16, 2023
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) February 16, 2023 23:44
@edgarrmondragon edgarrmondragon merged commit eb2b908 into meltano:main Feb 16, 2023
@flexponsive flexponsive deleted the e2e_cookiecutter_all_rest_auth branch February 17, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants