Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incompatible isort and python version in cookiecutter template #1402

Closed
longtomjr opened this issue Feb 8, 2023 · 1 comment · Fixed by #1406
Closed

[Bug]: Incompatible isort and python version in cookiecutter template #1402

longtomjr opened this issue Feb 8, 2023 · 1 comment · Fixed by #1406
Assignees
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@longtomjr
Copy link

longtomjr commented Feb 8, 2023

Singer SDK Version

0.19.0

Python Version

NA

Bug scope

Configuration (settings parsing, validation, etc.)

Operating System

Linux

Description

Good day.
I just created a new tap using the cookiecutter template, and the isort version is not compatible with the python version specified in the pyproject.toml. This was likely introduced here: #1360

Error from poetry install right after creating the project:

The current project's Python requirement (>=3.7.1,<3.12) is not compatible with some of the required packages Python requirement:
  - isort requires Python >=3.8.0, so it will not be satisfied for Python >=3.7.1,<3.8.0
@longtomjr longtomjr added kind/Bug Something isn't working valuestream/SDK labels Feb 8, 2023
@edgarrmondragon edgarrmondragon self-assigned this Feb 8, 2023
@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Feb 8, 2023

@longtomjr A temporary workaround is to change the isort requirement in pyproject.toml in the generated project to a compatible version:

- isort = "^5.12.0"
+ isort = "^5.11.5"

then run poetry lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants