Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add incremental replication example #1390

Merged

Conversation

flexponsive
Copy link
Contributor

@flexponsive flexponsive commented Feb 6, 2023

adds a new docs page with an example of incremental replication based on a time field; closes #1372


📚 Documentation preview 📚: https://meltano-sdk--1390.org.readthedocs.build/en/1390/

@flexponsive flexponsive requested review from a team as code owners February 6, 2023 16:25
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1390 (efbb219) into main (92dd45a) will not change coverage.
The diff coverage is n/a.

❗ Current head efbb219 differs from pull request most recent head cd2bcc1. Consider uploading reports for the commit cd2bcc1 to get more accurate results

@@           Coverage Diff           @@
##             main    #1390   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files          54       54           
  Lines        4722     4722           
  Branches      803      803           
=======================================
  Hits         4023     4023           
  Misses        507      507           
  Partials      192      192           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davegot12
Copy link

Thank you @flexponsive for this PR, I was the original poster on Slack for this documentation and you beat me to it :)

I left two comments with suggestion that could add a bit more depth to the docs, feel free to take them into account or not.

@tayloramurphy
Copy link
Collaborator

@aaronsteers @edgarrmondragon can you give this a review when you're able to?

Thanks @flexponsive for the PR!

docs/incremental_replication.md Outdated Show resolved Hide resolved
docs/incremental_replication.md Outdated Show resolved Hide resolved
docs/incremental_replication.md Outdated Show resolved Hide resolved
docs/incremental_replication.md Outdated Show resolved Hide resolved
docs/incremental_replication.md Outdated Show resolved Hide resolved
docs/incremental_replication.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @flexponsive for the PR, and @davegot12 for your suggestions!

@edgarrmondragon edgarrmondragon requested review from aaronsteers and removed request for aaronsteers February 8, 2023 17:18
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) February 8, 2023 17:19
@edgarrmondragon edgarrmondragon merged commit c9c7ee8 into meltano:main Feb 8, 2023
@flexponsive
Copy link
Contributor Author

Thank you for the feedback and improvements!

@flexponsive flexponsive deleted the docs_incremental_replication_example branch February 8, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Add usage example of Stream.get_starting_timesamp()
4 participants