Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove tox dependency from tap/target template #1345

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

WillDaSilva
Copy link
Member

@WillDaSilva WillDaSilva commented Jan 24, 2023

Per @edgarrmondragon's suggestion, the documentation has been updated to suggest it be installed using pipx

Closes #1311


📚 Documentation preview 📚: https://meltano-sdk--1345.org.readthedocs.build/en/1345/

The documentation has been updated to suggest it be installed using `pipx`.

Closes #1311
@WillDaSilva WillDaSilva self-assigned this Jan 24, 2023
@WillDaSilva WillDaSilva marked this pull request as ready for review January 24, 2023 21:57
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1345 (dc382e7) into main (2def28b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1345   +/-   ##
=======================================
  Coverage   84.54%   84.54%           
=======================================
  Files          44       44           
  Lines        4192     4192           
  Branches      726      726           
=======================================
  Hits         3544     3544           
  Misses        474      474           
  Partials      174      174           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WillDaSilva WillDaSilva merged commit c852b99 into main Jan 24, 2023
@WillDaSilva WillDaSilva deleted the 1311-remove-tox-dep branch January 24, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: poetry incorrectly tries to resolve an unnecessary importlib-metadata dependency
2 participants