Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove SQLSink snakecase conform in favor of simpler transformations #1342

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Jan 24, 2023

Closes #1205


📚 Documentation preview 📚: https://meltano-sdk--1342.org.readthedocs.build/en/1342/

@kgpayne kgpayne changed the title remove snakecase in favour of simpler transformations fix: remove SQLSink snakecase conform in favour of simpler transformations Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1342 (8286517) into main (5db1b50) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
- Coverage   85.19%   85.12%   -0.07%     
==========================================
  Files          54       54              
  Lines        4694     4694              
  Branches      798      798              
==========================================
- Hits         3999     3996       -3     
- Misses        504      507       +3     
  Partials      191      191              
Impacted Files Coverage Δ
singer_sdk/sinks/sql.py 89.18% <100.00%> (ø)
singer_sdk/helpers/_conformers.py 76.92% <0.00%> (-23.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgpayne kgpayne marked this pull request as ready for review January 25, 2023 22:04
@aaronsteers aaronsteers changed the title fix: remove SQLSink snakecase conform in favour of simpler transformations change: remove SQLSink snakecase conform in favour of simpler transformations Feb 1, 2023
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @kgpayne !

singer_sdk/sinks/sql.py Show resolved Hide resolved
@aaronsteers aaronsteers changed the title change: remove SQLSink snakecase conform in favour of simpler transformations fix: remove SQLSink snakecase conform in favour of simpler transformations Feb 1, 2023
@aaronsteers aaronsteers changed the title fix: remove SQLSink snakecase conform in favour of simpler transformations fix: remove SQLSink snakecase conform in favor of simpler transformations Feb 1, 2023
@kgpayne kgpayne merged commit 8426846 into main Feb 2, 2023
@kgpayne kgpayne deleted the kgpayne/issue1205 branch February 2, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Schema conforming should not auto-add underscores to table and column names
3 participants