fix(taps): Replace hyphens with underscores when generating expected env var name <PLUGIN_NAME>_LOGLEVEL
#1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we're looking for `cls.name.upper()`, with hyphens intact. This change makes this variable match other plugin specific variables by replacing hyphens with underscores. Also, fix a formatting glitch in the contributing guide.
adherr
requested review from
afolson,
tayloramurphy,
a team,
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
edgarrmondragon
changed the title
<PLUGIN_NAME>_LOGLEVEL
aaronsteers
approved these changes
Jan 4, 2023
|
Thanks @adherr, merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're looking for
cls.name.upper(), with hyphens intact. Since hyphens are not allowed in shell variable names, this makes it impossible to set the loglevel for a single tap. This change makes this variable match other plugin specific variables by replacing hyphens with underscores.Also, fix a formatting glitch in the contributing guide.
📚 Documentation preview 📚: https://meltano-sdk--1308.org.readthedocs.build/en/1308/