-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automatic catalog selection of replication keys #1283
feat: Automatic catalog selection of replication keys #1283
Conversation
84b48a8
to
0c15fef
Compare
Codecov Report
@@ Coverage Diff @@
## main #1283 +/- ##
=======================================
Coverage 84.53% 84.54%
=======================================
Files 44 44
Lines 4190 4192 +2
Branches 725 726 +1
=======================================
+ Hits 3542 3544 +2
Misses 474 474
Partials 174 174
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@edgarrmondragon awesome stuff! Fixes this one for everybody |
@kgpayne can you think of any undesired consequences of doing this? I don't think many folks are relying on the replication key not being selected by default. Wdyt? |
@edgarrmondragon I can't think of any reason not to select replication keys by default 🙂 Users can always override if necessary too, so seems like a good default behaviour to me 👍 |
Closes #1217
📚 Documentation preview 📚: https://meltano-sdk--1283.org.readthedocs.build/en/1283/