Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support patternProperties in JSON schema helpers #1197

Merged
merged 7 commits into from
Nov 16, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 16, 2022

Closes #1189


📚 Documentation preview 📚: https://meltano-sdk--1197.org.readthedocs.build/en/1197/

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1197 (acc38f3) into main (61ed7b4) will increase coverage by 0.03%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   83.56%   83.59%   +0.03%     
==========================================
  Files          42       42              
  Lines        3881     3908      +27     
  Branches      659      665       +6     
==========================================
+ Hits         3243     3267      +24     
- Misses        474      475       +1     
- Partials      164      166       +2     
Impacted Files Coverage Δ
singer_sdk/sinks/sql.py 89.18% <60.00%> (-1.47%) ⬇️
singer_sdk/target_base.py 86.89% <93.75%> (+0.45%) ⬆️
singer_sdk/_singerlib/__init__.py 100.00% <100.00%> (ø)
singer_sdk/helpers/capabilities.py 91.52% <100.00%> (+0.14%) ⬆️
singer_sdk/typing.py 94.89% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 16, 2022 16:24
@edgarrmondragon edgarrmondragon changed the title feat: Support patternProperties feat: Support patternProperties in JSON schema helpers Nov 16, 2022
Copy link
Contributor

@cjohnhanson cjohnhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@edgarrmondragon edgarrmondragon merged commit c4e2301 into main Nov 16, 2022
@edgarrmondragon edgarrmondragon deleted the feat/pattern-properties branch November 16, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support patternProperties in JSON Schema helpers
3 participants