-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support patternProperties
in JSON schema helpers
#1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Codecov Report
@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
+ Coverage 83.56% 83.59% +0.03%
==========================================
Files 42 42
Lines 3881 3908 +27
Branches 659 665 +6
==========================================
+ Hits 3243 3267 +24
- Misses 474 475 +1
- Partials 164 166 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
requested review from
a team,
afolson,
tayloramurphy,
cjohnhanson and
aaronsteers
as code owners
November 16, 2022 16:24
afolson
approved these changes
Nov 16, 2022
edgarrmondragon
changed the title
feat: Support
feat: Support Nov 16, 2022
patternProperties
patternProperties
in JSON schema helpers
cjohnhanson
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1189
📚 Documentation preview 📚: https://meltano-sdk--1197.org.readthedocs.build/en/1197/