Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Built-in handling of default-target-schema for SQL Targets #1157

Conversation

BuzzCutNorman
Copy link
Contributor

@BuzzCutNorman BuzzCutNorman commented Nov 8, 2022

This is an attempt to add support for a default_target_schema , as mentioned in issue #1086, into the SDK for SQL Targets.


📚 Documentation preview 📚: https://meltano-sdk--1157.org.readthedocs.build/en/1157/

singer_sdk/sinks/sql.py Outdated Show resolved Hide resolved
singer_sdk/sinks/sql.py Outdated Show resolved Hide resolved
singer_sdk/sinks/sql.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module supports PEP 585

singer_sdk/target_base.py Outdated Show resolved Hide resolved
singer_sdk/target_base.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1157 (601c5e2) into main (61ed7b4) will decrease coverage by 0.03%.
The diff coverage is 86.36%.

❗ Current head 601c5e2 differs from pull request most recent head 3e599fa. Consider uploading reports for the commit 3e599fa to get more accurate results

@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
- Coverage   83.56%   83.53%   -0.04%     
==========================================
  Files          42       42              
  Lines        3881     3892      +11     
  Branches      659      661       +2     
==========================================
+ Hits         3243     3251       +8     
- Misses        474      475       +1     
- Partials      164      166       +2     
Impacted Files Coverage Δ
singer_sdk/sinks/sql.py 89.18% <60.00%> (-1.47%) ⬇️
singer_sdk/target_base.py 86.02% <93.75%> (-0.43%) ⬇️
singer_sdk/helpers/capabilities.py 91.52% <100.00%> (+0.14%) ⬆️
singer_sdk/tap_base.py 68.51% <0.00%> (-0.15%) ⬇️
singer_sdk/connectors/sql.py 77.77% <0.00%> (-0.09%) ⬇️
singer_sdk/_singerlib/messages.py 100.00% <0.00%> (+2.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BuzzCutNorman BuzzCutNorman marked this pull request as ready for review November 10, 2022 15:14
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) November 16, 2022 19:05
@edgarrmondragon
Copy link
Collaborator

Forgot to merge this one 😅.

Thanks @BuzzCutNorman!

@edgarrmondragon edgarrmondragon merged commit aaa68aa into meltano:main Nov 16, 2022
@BuzzCutNorman BuzzCutNorman deleted the 1086-feat-built-in-handling-default-target-schedule branch November 28, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants