Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix duplicate Known Limitations header #1133

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 1, 2022

$ grep -nri "known limitations" docs
docs/stream_maps.md:359:## Known Limitations
docs/batch.md:97:## Known Limitations

Read the Docs builds are failing because of this


📚 Documentation preview 📚: https://meltano-sdk--1133.org.readthedocs.build/en/1133/

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1133 (e9ca016) into main (4b37cad) will not change coverage.
The diff coverage is n/a.

❗ Current head e9ca016 differs from pull request most recent head e93fa4c. Consider uploading reports for the commit e93fa4c to get more accurate results

@@           Coverage Diff           @@
##             main    #1133   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files          42       42           
  Lines        3855     3855           
  Branches      658      658           
=======================================
  Hits         3218     3218           
  Misses        472      472           
  Partials      165      165           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 1, 2022 14:45
@edgarrmondragon edgarrmondragon requested review from a team as code owners November 1, 2022 14:45
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't find anything referencing here the old tag, so this shouldn't break any links within the SDK docs.

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) November 1, 2022 14:48
@edgarrmondragon edgarrmondragon merged commit b20216d into main Nov 1, 2022
@edgarrmondragon edgarrmondragon deleted the docs/fix-duplicate-headers branch November 1, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants