Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JSON Schema Property helpers for allowed_values (enum) and examples #1098

Merged
merged 28 commits into from
Oct 24, 2022

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Oct 21, 2022

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #1098 (e640769) into main (6cdb0fd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head e640769 differs from pull request most recent head a48c7a2. Consider uploading reports for the commit a48c7a2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
+ Coverage   83.41%   83.43%   +0.02%     
==========================================
  Files          40       40              
  Lines        3840     3846       +6     
  Branches      655      657       +2     
==========================================
+ Hits         3203     3209       +6     
  Misses        472      472              
  Partials      165      165              
Impacted Files Coverage Δ
singer_sdk/typing.py 94.73% <100.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronsteers
Copy link
Contributor Author

@edgarrmondragon - Do you mind taking a quick look at this?

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aaronsteers aaronsteers merged commit 6607487 into main Oct 24, 2022
@aaronsteers aaronsteers deleted the aj-more-type-helpers branch October 24, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants