-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add secrets support for tap and target config, via Property(..., secret=True)
#1096
Merged
aaronsteers
merged 22 commits into
main
from
77-feat-secrets-support-in-config-and-streams
Oct 21, 2022
Merged
feat: add secrets support for tap and target config, via Property(..., secret=True)
#1096
aaronsteers
merged 22 commits into
main
from
77-feat-secrets-support-in-config-and-streams
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsteers
requested review from
edgarrmondragon and
cjohnhanson
as code owners
October 20, 2022 23:20
5 tasks
edgarrmondragon
requested changes
Oct 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
- Coverage 83.60% 83.41% -0.19%
==========================================
Files 40 40
Lines 3805 3840 +35
Branches 640 655 +15
==========================================
+ Hits 3181 3203 +22
- Misses 464 472 +8
- Partials 160 165 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
approved these changes
Oct 21, 2022
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…://github.com/meltano/sdk into 77-feat-secrets-support-in-config-and-streams
aaronsteers
changed the title
feat: add secrets support in config and streams
feat: add secrets support for tap and target config, via Oct 21, 2022
Property(..., secret=True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
writeOnly=True
support for passwords and other secrets, as per the JSON Schema spec.secret=True
annotation to help with readability for humans.Property
type helper class now now implements both of the above via asecret=True
argument in the constructor.schema
declarations for streams.Todo:
[ ] Docs for stream schema creationNote: