Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document an example implementation and usage of BaseHATEOASPaginator #1074

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 14, 2022

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (0bbe4cb) to head (87f1e3d).
Report is 1071 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files          39       39           
  Lines        3747     3747           
  Branches      628      628           
=======================================
  Hits         3115     3115           
  Misses        470      470           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon
Copy link
Collaborator Author

https://meltano-sdk--1074.org.readthedocs.build/en/1074/classes/singer_sdk.pagination.BaseHATEOASPaginator.html

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 14, 2022 21:40
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) October 15, 2022 01:09
@edgarrmondragon edgarrmondragon merged commit b9f693b into main Oct 15, 2022
@edgarrmondragon edgarrmondragon deleted the docs/example-hateoas-pagination branch October 15, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants