-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support conforming singer property names to target identifier constraints in SQL sinks #1039
Conversation
@aaronsteers @edgarrmondragon here is my first-pass attempt at column name conforming. The new "SampleTapHostile" tests are passing, and I think cover most of the common DBMS identifier constraints. Let me know what you think of the overall approach, and if there are other test cases worth adding 👍 |
Co-authored-by: Edgar R. M. <[email protected]>
Co-authored-by: Edgar R. M. <[email protected]>
Co-authored-by: Edgar R. M. <[email protected]>
Co-authored-by: Edgar R. M. <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
+ Coverage 83.39% 83.43% +0.03%
==========================================
Files 39 40 +1
Lines 3758 3815 +57
Branches 628 642 +14
==========================================
+ Hits 3134 3183 +49
- Misses 464 471 +7
- Partials 160 161 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3f9aa9e
to
2721dc5
Compare
Closes #1021
📚 Documentation preview 📚: https://meltano-sdk--1039.org.readthedocs.build/en/1039/