Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support conforming singer property names to target identifier constraints in SQL sinks #1039

Merged
merged 38 commits into from
Oct 20, 2022

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Oct 5, 2022

@kgpayne kgpayne changed the base branch from main to kgpayne/issue1027 October 5, 2022 16:56
@kgpayne
Copy link
Contributor Author

kgpayne commented Oct 5, 2022

@aaronsteers @edgarrmondragon here is my first-pass attempt at column name conforming. The new "SampleTapHostile" tests are passing, and I think cover most of the common DBMS identifier constraints. Let me know what you think of the overall approach, and if there are other test cases worth adding 👍

singer_sdk/sinks/sql.py Outdated Show resolved Hide resolved
singer_sdk/sinks/sql.py Show resolved Hide resolved
singer_sdk/sinks/sql.py Outdated Show resolved Hide resolved
singer_sdk/sinks/sql.py Outdated Show resolved Hide resolved
singer_sdk/sinks/sql.py Outdated Show resolved Hide resolved
samples/sample_tap_hostile/hostile_streams.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1039 (0d7c431) into main (2721dc5) will increase coverage by 0.03%.
The diff coverage is 91.00%.

❗ Current head 0d7c431 differs from pull request most recent head fd1a7a6. Consider uploading reports for the commit fd1a7a6 to get more accurate results

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   83.39%   83.43%   +0.03%     
==========================================
  Files          39       40       +1     
  Lines        3758     3815      +57     
  Branches      628      642      +14     
==========================================
+ Hits         3134     3183      +49     
- Misses        464      471       +7     
- Partials      160      161       +1     
Impacted Files Coverage Δ
singer_sdk/streams/sql.py 80.27% <80.95%> (ø)
singer_sdk/sinks/sql.py 84.61% <90.90%> (-2.40%) ⬇️
singer_sdk/exceptions.py 100.00% <100.00%> (ø)
singer_sdk/helpers/_conformers.py 100.00% <100.00%> (ø)
singer_sdk/sinks/core.py 80.64% <100.00%> (+0.38%) ⬆️
singer_sdk/target_base.py 85.44% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

singer_sdk/sinks/sql.py Outdated Show resolved Hide resolved
@kgpayne kgpayne marked this pull request as ready for review October 13, 2022 11:08
@kgpayne kgpayne requested a review from cjohnhanson as a code owner October 13, 2022 11:08
Base automatically changed from kgpayne/issue1027 to main October 19, 2022 22:28
@kgpayne kgpayne closed this Oct 20, 2022
@kgpayne kgpayne reopened this Oct 20, 2022
@kgpayne kgpayne enabled auto-merge (squash) October 20, 2022 14:21
@kgpayne kgpayne merged commit 937acf3 into main Oct 20, 2022
@kgpayne kgpayne deleted the kgpayne/issue1021 branch October 20, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support column name conforming
3 participants