From ee2552aead31c6acf47705b3d86fbd460088c138 Mon Sep 17 00:00:00 2001
From: "Edgar R. M" <edgar@meltano.com>
Date: Wed, 15 Mar 2023 18:06:53 -0600
Subject: [PATCH] chore: Enable `INP` Ruff checks (#1501)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<h2>Rationale</h2>

<p>Implicit namespace packages are directories of Python files without an <code>__init__.py</code>.
    They’re valid and importable, but they break <em>many</em> tools, such as:</p>

<ul>
    <li><p><a href="https://bugs.python.org/issue23882" rel="nofollow">unittest test discovery</a> (and by extension, Django’s test runner)</p></li>
    <li><p><a href="https://github.com/nedbat/coveragepy/issues/1024" rel="nofollow">Coverage.py</a></p></li>
    <li><p>Mypy without its <a href="https://mypy.readthedocs.io/en/latest/command_line.html#import-discovery" rel="nofollow">–namespace-packages option</a></p></li>
    <li><p><a href="https://github.com/pytest-dev/pytest/issues/5147" rel="nofollow">pytest</a></p></li>
</ul>

https://pypi.org/project/flake8-no-pep420/
---
 pyproject.toml                       | 7 ++++++-
 samples/aapl/__init__.py             | 0
 tests/_singerlib/__init__.py         | 0
 tests/cookiecutters/__init__.py      | 0
 tests/core/configuration/__init__.py | 0
 tests/core/rest/__init__.py          | 0
 tests/samples/__init__.py            | 0
 7 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 samples/aapl/__init__.py
 create mode 100644 tests/_singerlib/__init__.py
 create mode 100644 tests/cookiecutters/__init__.py
 create mode 100644 tests/core/configuration/__init__.py
 create mode 100644 tests/core/rest/__init__.py
 create mode 100644 tests/samples/__init__.py

diff --git a/pyproject.toml b/pyproject.toml
index 6ec4b6173..828a814a9 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -232,6 +232,7 @@ select = [
     "T10",  # flake8-debugger
     "ISC",  # flake8-implicit-str-concat
     "ICN",  # flake8-import-conventions
+    "INP",  # flake8-no-pep420
     "PIE",  # flake8-pie
     "PT",   # flake8-pytest-style
 ]
@@ -239,7 +240,11 @@ src = ["samples", "singer_sdk", "tests"]
 target-version = "py37"
 
 [tool.ruff.per-file-ignores]
-"docs/conf.py" = ["D", "I002"]
+"docs/conf.py" = [
+    "D",      # pydocstyle/flake8-docstrings
+    "I002",   # isort: missing-required-import
+    "INP001", # flake8-no-pep420: implicit-namespace-package
+]
 "noxfile.py" = ["ANN"]
 "tests/*" = ["ANN", "D1", "D2"]
 # Disabled some checks in samples code
diff --git a/samples/aapl/__init__.py b/samples/aapl/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/tests/_singerlib/__init__.py b/tests/_singerlib/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/tests/cookiecutters/__init__.py b/tests/cookiecutters/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/tests/core/configuration/__init__.py b/tests/core/configuration/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/tests/core/rest/__init__.py b/tests/core/rest/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/tests/samples/__init__.py b/tests/samples/__init__.py
new file mode 100644
index 000000000..e69de29bb