Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit scaling #1

Open
dmeliza opened this issue Apr 4, 2018 · 1 comment
Open

unit scaling #1

dmeliza opened this issue Apr 4, 2018 · 1 comment
Assignees
Labels

Comments

@dmeliza
Copy link
Member

dmeliza commented Apr 4, 2018

Units aren't being scaled correctly by to_array. For example, if capacitance is entered in the yml file as nF or pF, the units are ignored. But for dV/dt to have the right units of mV/ms, the capacitance has to be corrected to pF.

@dmeliza dmeliza added the bug label Apr 4, 2018
@dmeliza dmeliza self-assigned this Apr 4, 2018
@dmeliza
Copy link
Member Author

dmeliza commented Apr 4, 2018

This isn't trivial to fix. It's simple enough to convert all the parameters to base units. This doesn't affect the magnitude of dV/dt, but it does affect all the state derivatives because they're in ms^-1. For now, users need to be careful to enter compatible units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant