Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet points not changing color with tagStyles for ul / li #151

Closed
JungleCatSW opened this issue May 18, 2018 · 3 comments · Fixed by #434
Closed

Bullet points not changing color with tagStyles for ul / li #151

JungleCatSW opened this issue May 18, 2018 · 3 comments · Fixed by #434
Labels
bug:minor Low priority bug. bug Crush'em all.

Comments

@JungleCatSW
Copy link

Is this a bug report or a feature request?

Bug report

Have you read the guidelines regarding bug report?

Yes

Have you read the documentation in its entirety?

Yes

Have you made sure that your issue hasn't already been reported/solved?

Yes

Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?

Both
(Write your answer here and specify the iOS/Android versions on which you've been able to reproduce the issue.)
iPhone 5, iPhone 6, Galaxy Tab 3, Galaxy S8, Nexus 5, Galaxy A3

Is the bug reproductible in a production environment (not a debug one)?

Yes

Have you been able to reproduce the bug in the provided example?

Yes

Environment

Environment:
React: 16.0.0
React native: 0.52
react-native-render-html: 3.10.0

Target Platform:
Android 8.1 / 27
iOS 11

Steps to Reproduce

When using custom tagStyles to color bulleted lists the bullet image doesn't change color but the text does.

Please see snack
Snack of issue

Expected Behavior

I though the bullet point images would be the same color as the text.

Actual Behavior

The bullet points stayed black.

screenshot_20180518-111347_expo

Reproducible Demo

Please see snack

Snack of issue

@JungleCatSW
Copy link
Author

Also I'm fairly sure its line 91 of this file https://github.com/archriss/react-native-render-html/blob/master/src/HTMLRenderers.js that needs to take the color style from props ?

@Exilz Exilz added the bug:minor Low priority bug. label Jun 13, 2018
@donni106
Copy link

donni106 commented Aug 9, 2018

@JungleCatSW do you made it?
I think you need a special listsPrefixesRenderers to color the bullets or numbers. See #165 (comment) how to do it.

@jsamr jsamr added the bug Crush'em all. label Jul 19, 2020
@jsamr jsamr linked a pull request Nov 26, 2020 that will close this issue
41 tasks
@jsamr jsamr mentioned this issue Nov 26, 2020
41 tasks
@jsamr
Copy link
Collaborator

jsamr commented Nov 27, 2020

This issue has been fixed in the Foundry release. Try it out now! See #430 for instructions.

@jsamr jsamr closed this as completed in #434 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:minor Low priority bug. bug Crush'em all.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants