-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support Cypress v5.0 (test-retries) #141
base: master
Are you sure you want to change the base?
Conversation
Thanks for the work. I always tried to be backwards compatible. Have to think about if I want to break backwards compatibility. I do encourage users to keep up to date with latest Cypress version. |
@meinaart This is backwards compatible. However the tests for the plugin will fail on a previous Cypress version. I'll add some code to test on multiple Cypress versions |
@meinaart take a look at the changes to CI, I've added testing for previous versions of cypress and 5.0. |
+1 |
1 similar comment
+1 |
+1 |
Any update? |
Eagerly awaiting an update on this too :) |
Hope we can get this merged soon! |
Any update on this? Would love to see it merged in, and looks ready to go? cc @meinaart |
Any news here ? |
Would be good to rebase this with latest master @bkucera |
Any progress on this? |
Hi, Cypress version
5.0
is landing soon, and included in that release istest-retries
, which will break this plugin. Thankfully only a few changes were needed to support5.0
, so I've included them in this PR.Although the changes in this PR will not break Cypress versions <5.0, This PR's tests will fail since it's expecting test-retries support. So I would recommend waiting for the Cypress
5.0
release and then updating to run against5.0
before merging.Additional Info
to test against the 5.0 prerelease, I've used the following (Linux/docker):
Edit
5.0 is released, I've added CI test runs for 5.0 in addition to previous versions of Cypress.