Fix miri issues with bbbul #1
Merged
+74
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are building a forward linked list, by the time we modify a node to set its successor, that node is already referenced in its predecessor. That means that we cannot claim exclusive ownership to the node whose successor we want to set. Instead, we're using interior mutability to the `next_node` inside of the `Node` structure, so that we can do everything with shared references.
dureuill
commented
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are building a forward linked list, by the time we modify a node to set its successor, that node is already referenced in its predecessor.
That means that we cannot claim exclusive ownership to the node whose successor we want to set. Instead, we're using interior mutability to the
next_nodeinside of theNodestructure, so that we can do everything with shared references.I previously attempted to work around this problem by introducing a
before_tailstructure member, but the same issue would recursively appear.